981.update podman build by singhd789 · Pull Request #982 · NOAA-GFDL/fre-cli

singhd789 · 2026-09-29T20:46:09Z

Describe your changes

add --network host to podman build step (a bit hard to constrain because this workaround is ONLY for GAEA though)
adjust tests
build_conda.yaml was failing - install libmamba as a conda solver to help build

Issue ticket number and link (if applicable)

Fixes #981

Checklist before requesting a review

I ran my code
I tried to make my code readable
I tried to comment my code
I wrote a new test, if applicable
I wrote new instructions/documentation, if applicable
I ran pytest and inspected it's output
I ran pylint and attempted to implement some of it's feedback
No print statements; all user-facing info uses logging module

Note: If you are a code maintainer updating the tag or releasing a new fre-cli version, please use the release_procedure.md template. To quickly use this template, open a new pull request, choose your branch, and add ?template=release_procedure.md to the end of the url.

Copilot

Copilot review overview

🟡 Changes recommended

The generated commands use an unsupported podman build --net flag instead of --network.

Review effort: Balanced
Findings: 1 · 1

Open (2)

Use supported --network option for Podman builds · New
Update assertion to expect supported Podman network option · New

What changed in this PR

Adds host networking to generated container build commands.

Changes:

Adds host networking to builds with and without volume mounts.
Updates the generated-script test expectation.

File	Description
`fre/make/gfdlfremake/buildDocker.py`	Adds host networking to container builds.
`fre/make/tests/test_create_dockerfile.py`	Updates the expected build command.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

…inghd789/fre-cli into 981.update-podman-build

codecov · 2026-09-29T21:08:52Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.46%. Comparing base (22c9739) to head (219a553).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #982      +/-   ##
==========================================
+ Coverage   83.45%   83.46%   +0.01%     
==========================================
  Files          68       68              
  Lines        3808     3811       +3     
==========================================
+ Hits         3178     3181       +3     
  Misses        630      630

Flag	Coverage Δ
unittests	`83.46% <100.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
fre/make/gfdlfremake/buildDocker.py	`91.20% <100.00%> (+0.21%)`	⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22c9739...219a553. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…inghd789/fre-cli into 981.update-podman-build

Copilot

Copilot review overview

🟡 Changes recommended

Host networking is incorrectly applied to Docker builds as well as Podman builds.

Review effort: Balanced
Findings: 1 · 1

Open (2)

Apply host networking only for Podman builds · New
Wrap test string to satisfy 120-character Pylint limit · New

Resolved since last review (2)

Use supported --network option for Podman builds
Update assertion to expect supported Podman network option

…inghd789/fre-cli into 981.update-podman-build

singhd789 · 2026-10-15T14:00:15Z

Note: I did test a container build on the amd box and it worked

Copilot

🟢 Approval recommended

The focused workaround preserves Docker behavior, and the updated test expectations match the generated commands.

0 open findings

2 resolved since last review

🧠 Review effort: Balanced

NOAA-GFDL#981 update podman build

c9d7759

Copilot AI balanced review requested due to automatic review settings September 29, 2026 20:46

Copilot started reviewing on behalf of singhd789 September 29, 2026 20:46

View session

Merge branch 'main' into 981.update-podman-build

31a467f

Copilot AI reviewed Sep 29, 2026

View reviewed changes

Comment thread fre/make/gfdlfremake/buildDocker.py Outdated

Comment thread fre/make/tests/test_create_dockerfile.py Outdated

Dana Singh added 2 commits September 29, 2026 16:58

NOAA-GFDL#981 add --net=host

e9230e9

NOAA-GFDL#981 Merge branch '981.update-podman-build' of github.com:s…

d6fd6c0

…inghd789/fre-cli into 981.update-podman-build

singhd789 linked an issue Sep 29, 2026 that may be closed by this pull request

fre make: podman build command needs an update #981

Closed

Merge branch 'main' into 981.update-podman-build

2e98edc

singhd789 requested a review from thomas-robinson October 1, 2026 17:33

Dana Singh added 2 commits October 1, 2026 15:01

NOAA-GFDL#981 update net to network

3e15fb5

NOAA-GFDL#981 Merge branch '981.update-podman-build' of github.com:s…

35b735d

…inghd789/fre-cli into 981.update-podman-build

singhd789 requested a balanced review from Copilot October 1, 2026 19:03

Copilot started reviewing on behalf of singhd789 October 1, 2026 19:03

View session

Copilot AI reviewed Oct 1, 2026

View reviewed changes

Comment thread fre/make/gfdlfremake/buildDocker.py Outdated

Comment thread fre/make/tests/test_create_dockerfile.py Outdated

Dana Singh and others added 14 commits October 5, 2026 11:33

NOAA-GFDL#981 attempt to fix conda build

a02094a

NOAA-GFDL#981 try using classic conda solver

25c9bbe

NOAA-GFDL#981 add timeout

9ddb663

NOAA-GFDL#981 try libmamba

0a7da7a

NOAA-GFDL#981 try installing libmamba

63ee19e

NOAA-GFDL#981 no plugins

fe41b19

NOAA-GFDL#981 comment out

1387274

NOAA-GFDL#981 set no_plugins for just the test of the build

74c66c1

NOAA-GFDL#981 add libmamba solver to test env

b380430

NOAA-GFDL#981 check for codna build

a15ee01

NOAA-GFDL#981 test conda-build and plugins

297b9dd

NOAA-GFDL#981 do plugins work?

b560809

NOAA-GFDL#981 clean up

43ce6aa

NOAA-GFDL#981 address comment

7c74170

Dana Singh and others added 5 commits October 8, 2026 10:06

NOAA-GFDL#981 workaround only for podman

b9a3855

Merge branch 'main' into 981.update-podman-build

b6c65c1

NOAA-GFDL#981 try pinning versions

8f05372

NOAA-GFDL#981 Merge branch '981.update-podman-build' of github.com:s…

42228dd

…inghd789/fre-cli into 981.update-podman-build

NOAA-GFDL#981 typo

c4963ae

ceblanton reviewed Oct 13, 2026

View reviewed changes

Comment thread .github/workflows/build_conda.yml Outdated

ceblanton reviewed Oct 13, 2026

View reviewed changes

Comment thread fre/make/tests/test_create_dockerfile.py

NOAA-GFDL#981 remove conda build version pin

0fd57f8

Merge branch 'main' into 981.update-podman-build

219a553

thomas-robinson approved these changes Oct 15, 2026

View reviewed changes

thomas-robinson requested a balanced review from Copilot October 15, 2026 15:37

Copilot started reviewing on behalf of thomas-robinson October 15, 2026 15:37

View session

Copilot AI reviewed Oct 15, 2026

View reviewed changes

singhd789 merged commit ea0634b into NOAA-GFDL:main Oct 15, 2026
10 checks passed

singhd789 deleted the 981.update-podman-build branch October 15, 2026 16:39

Navigation Menu

Repository navigation

981.update podman build - #982

981.update podman build#982
singhd789 merged 28 commits into
NOAA-GFDL:mainfrom
singhd789:981.update-podman-build

singhd789 commented Sep 29, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Sep 29, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

singhd789 commented Oct 15, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

singhd789 commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes

Issue ticket number and link (if applicable)

Checklist before requesting a review

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

singhd789 commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

singhd789 commented Sep 29, 2026 •

edited

Loading

codecov Bot commented Sep 29, 2026 •

edited

Loading

singhd789 commented Oct 15, 2026 •

edited

Loading